Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Value Parser #136

Open
inveterateliterate opened this issue Sep 2, 2022 · 0 comments · May be fixed by #143
Open

Refactor Value Parser #136

inveterateliterate opened this issue Sep 2, 2022 · 0 comments · May be fixed by #143
Assignees

Comments

@inveterateliterate
Copy link
Contributor

I was flipping through all the parsers and I wonder if there's a bigger refactor available here: ValueParser could handle the array and empty checks. HashParser doesn't inherit from ValueParser (not totally sure why) but perhaps by the same logic ArrayParser could inherit from Base. All the other parsers do these same two checks. I haven't done a deep dive to test that out but wanted to surface

@nicoledow nicoledow self-assigned this Nov 28, 2023
@nicoledow nicoledow linked a pull request Dec 1, 2023 that will close this issue
3 tasks
@nicoledow nicoledow linked a pull request Dec 1, 2023 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants