Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not refund own address #2

Open
agouin opened this issue Apr 12, 2023 · 2 comments
Open

Should not refund own address #2

agouin opened this issue Apr 12, 2023 · 2 comments

Comments

@agouin
Copy link

agouin commented Apr 12, 2023

The transaction will attempt to refund the self delegation slash. This is a minor issue, as it doesn't really cause any issues, and was easy to manually remove. Filing this only because it is unnecessary to send funds from/to the same address.

@dylanschultzie
Copy link
Contributor

dylanschultzie commented Apr 12, 2023

@agouin interesting conundrum... I assumed people would refund with a non-validator wallet/burner wallet. If they do, then yeah, they'd refund themselves. Perhaps a simple conversation from valoper to *1 address would work.. though, if they're using a non-118 cointype it might not work.

Simplest solution would probably be to check if self is in the refund list, and exclude it.

Thanks for the issue!

@agouin
Copy link
Author

agouin commented Apr 12, 2023

Thank you for your tool! It was a wonderful help for our incident this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants