-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Duplicate font listed ("Inter") #4854
Comments
I've gone down a rabbit hole regarding the inner workings of Lawnchair's font system over the last couple of days and I think I've figured it out. I'll put together a pull request soon but, in the meantime, I'll put my intentions here:
(I've already tested this myself in a custom build and it all works great.) This seems like a good opportunity to update the internal font and keep things up-to-date. If you'd rather not update the font, please let me know. I could just name the internal font "Inter v3" instead. |
Back to the drawing board... Unless the label matches the actual font name, the variant styles do not display correctly in the drop-down menu or in the default/internal font labels (on the General page). It's a small thing but it's a backward step. Incidentally, the drop-down variant menu for the internal font lists 3 different italic variants, none of which are actually available. Also, the drop-down variant menu quite often needs to be opened twice to see the actual variant styles. I can see why the font section is labelled 'experimental'. (We could still update the internal font without breaking anything, though.) |
Perhaps the easiest solution would be to filter the Inter font from the Google Fonts list (so that there is only one Inter font: the internal one) and then add the missing variants to the internal Inter font so that they match all the variants that were available in the Google Fonts version. |
On further investigation,. both Inter entries use the Google Fonts version (neither uses the internal version), even though they have different sets of variants. Tested by replacing the internal Inter font files with an Inter Italic variant (which is not available in the Google Fonts version of Inter). The italic variant is used on first startup but not seen again when selecting either of the Inter versions from the font list (it is possible to separate the radio buttons if the variants of the two versions don't match). With this in mind, I think the easiest option might be to simply remove the second Inter entry (leaving the original Google Fonts version). I think I'll leave this to the devs for the time being. Edit: |
I'm still working on this (deeper down the rabbit hole)... I should soon be able to put together a PR which addresses several different font issues:
It's still a work-in-progress but it's taking shape and tests are going well. I just thought I'd give anyone following this issue an update to let them know that I've not abandoned it. |
Describe the bug
The font "Inter" is listed twice in the font list. Each entry has its own different set of variants (italic, medium, regular, etc.) but if you select either font, both radio buttons are highlighted. See screenshot.
Steps to reproduce
Steps to reproduce the behavior:
Expected behavior
I'd expect only once instance of each font to be listed (and only one radio button to be selected at any one time).
Screenshots
Device information
Additional context
No response
The text was updated successfully, but these errors were encountered: