Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple icon options for a single application #1371

Open
x9136 opened this issue Aug 3, 2023 · 4 comments
Open

Multiple icon options for a single application #1371

x9136 opened this issue Aug 3, 2023 · 4 comments

Comments

@x9136
Copy link
Collaborator

x9136 commented Aug 3, 2023

It is good when user has a choice of several icons. It can be either variants from different authors or a way to keep the old icon after redesigning an app. There are also companies that localize icons for different languages, such as Yandex.

In the implementation, most of the icons should be main icons, and additional variants should be bound to the same component via the "alt" parameter.

Now

<item component="ComponentInfo{giraffine.dimmer/giraffine.dimmer.Dimmer}" drawable="dimmer" name="Dimmer" />

Suggestion

<item component="ComponentInfo{giraffine.dimmer/giraffine.dimmer.Dimmer}" drawable="dimmer" alt={dimmer_giraffine, dimmer_square} name="Dimmer" />

This issue also applies to Lawnchair, because having several icons to choose from, it will be convenient to show them all in the "Customize" bottom sheet.

@KTibow
Copy link
Contributor

KTibow commented Aug 18, 2023

As someone who doesn't know too much about icon pack internals, is this something that all icon packs can implement already (eg can start using right away), or would it be more complicated than that?

@x9136
Copy link
Collaborator Author

x9136 commented Dec 21, 2023

Closed due to low usefulness and lack of noticeable interest among users.

@x9136 x9136 closed this as completed Dec 21, 2023
@x9136
Copy link
Collaborator Author

x9136 commented Jan 28, 2024

It might be useful. #1791

@x9136
Copy link
Collaborator Author

x9136 commented Jun 22, 2024

If this is implemented, then LawnchairLauncher/lawnchair#4268 should be done differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants