Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eigenda flags don't use same syntax as other flags #143

Closed
samlaf opened this issue Sep 20, 2024 · 1 comment
Closed

eigenda flags don't use same syntax as other flags #143

samlaf opened this issue Sep 20, 2024 · 1 comment

Comments

@samlaf
Copy link
Collaborator

samlaf commented Sep 20, 2024

Should we change the eigenda flags to use . instead of -: eigenda.<FLAG_NAME> instead of eigenda-<FLAG_NAME, like we do for all the other subsystem flags?
image
@epociask
Copy link
Collaborator

epociask commented Oct 2, 2024

closed by #146

@epociask epociask closed this as completed Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samlaf @epociask