Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.13 separate Claim and Claims classes into own files #377

Open
dpriskorn opened this issue Jul 19, 2022 · 2 comments · May be fixed by #381
Open

v0.13 separate Claim and Claims classes into own files #377

dpriskorn opened this issue Jul 19, 2022 · 2 comments · May be fixed by #381
Labels
enhancement New feature or request v0.12.x
Milestone
v0.13

Comments

@dpriskorn
Copy link
Contributor

I prefer not to have more than one class in each file to ease navigation.
@LeMyst
Copy link
Owner

LeMyst commented Jul 19, 2022

It was a choice at the beginning because the classes were small, but now it's a good idea to give each class is own file.

@LeMyst LeMyst added enhancement New feature or request v0.12.x labels Jul 19, 2022
@LeMyst LeMyst added this to the v0.13 milestone Jul 19, 2022
@LeMyst LeMyst linked a pull request Jul 21, 2022 that will close this issue
Draft
@LeMyst
Copy link
Owner

LeMyst commented Jul 24, 2022

Spliting the files create a lot of circular import, and I don't really understand why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request v0.12.x
Projects
None yet
Milestone
v0.13
Development

Successfully merging a pull request may close this issue.

Split model classes in its own file LeMyst/WikibaseIntegrator
2 participants
@LeMyst @dpriskorn