Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect pp calculation if it isn't a fc in other gamemodes (catch/taiko/mania) #1

Open
7mochi opened this issue Nov 22, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@7mochi
Copy link

7mochi commented Nov 22, 2021

Example code:

import fetch from 'node-fetch';
import { ctb_ppv2 } from 'booba';

const API_KEY = 'put api key here'; // osu! api v1 key
const USER = '4158549';

(async () => {
  const response = await fetch(`https://osu.ppy.sh/api/get_user_recent?k=${API_KEY}&u=${USER}&limit=1`);
  const json = await response.json();
  const [score] = json;

  const pp = new ctb_ppv2().setPerformance(score);

  console.log(await pp.compute())
  console.log(await pp.compute(true))
  // Both have the same output
})();

To make it simpler in the example code I use api v1 but in my project I'm using api v2

Attachments:
Untitled

@LeaPhant
Copy link
Owner

I have now added fc simulation to catch and taiko in 0.0.15, but it doesn't make much sense for mania since we can't know how much score the player would've gotten without messing up and mania pp is mostly based on score.

@LeaPhant LeaPhant added the enhancement New feature or request label Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants