Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 12.331 #2542

Open
JPMeehan opened this issue May 28, 2024 · 6 comments
Open

Version 12.331 #2542

JPMeehan opened this issue May 28, 2024 · 6 comments
Labels
foundry v12 This belongs to Foundry VTT version 12
Milestone
v12 Release

Comments

@JPMeehan
Copy link
Collaborator

JPMeehan commented May 28, 2024 •
edited
Loading

Task list

Client

Client-ESM

Common
@JPMeehan
Copy link
Collaborator Author

Context: v12.324 was v12 stable 1

@JPMeehan JPMeehan changed the title Version 12.325 Version 12.326 Jun 6, 2024
@JPMeehan
Copy link
Collaborator Author

JPMeehan commented Jun 6, 2024

v12 stable is about to drop and seems as good a target as any.

@JPMeehan JPMeehan changed the title Version 12.326 Version 12.327 Jun 8, 2024
@JPMeehan JPMeehan added the foundry v12 This belongs to Foundry VTT version 12 label Jun 8, 2024
@JPMeehan
Copy link
Collaborator Author

JPMeehan commented Jun 10, 2024 •
edited
Loading

Basic categories of things

  • Implement Regions #2574
  • Break up Shaders
  • Rework Primary Canvas Objects
  • Migrate Audio to client-esm
  • Migrate Rolls to client-esm
  • Migrate Canvas Sources to client-esm
  • Migrate Grid to common
  • Migrate Prosemirror to common
  • Implement AppV2

@JPMeehan JPMeehan changed the title Version 12.327 Version 12.328 Jun 24, 2024
@JPMeehan JPMeehan added this to the v12 Release milestone Jun 26, 2024
@JPMeehan JPMeehan pinned this issue Jul 7, 2024
@JPMeehan JPMeehan changed the title Version 12.328 Version 12.329 Jul 20, 2024
@JPMeehan JPMeehan changed the title Version 12.329 Version 12.330 Jul 26, 2024
@Abourass
Copy link

Just to be clear, is work on this to be forked from the V12 branch or the main branch?

The read-me suggest the main branch is where the current FVTT version is being worked on, but it seems most of the PR I see are from the V12 branch. I'd like to contribute some work on this, and just want to be sure where I should dig in?

@JPMeehan
Copy link
Collaborator Author

Just to be clear, is work on this to be forked from the V12 branch or the main branch?

The read-me suggest the main branch is where the current FVTT version is being worked on, but it seems most of the PR I see are from the V12 branch. I'd like to contribute some work on this, and just want to be sure where I should dig in?

  1. We have a work group in the League discord, in the fvtt-types-qwest channel.
  2. Normally work is branched from main but there's a bit of a holdup due to working out some data field related issues in v11/data-models, so we made v12/main to allow work on v12 to progress forward while those were resolved
  3. I strongly suggest picking any of the "Good First Issues", making a PR, and then we can fill you in. A lot of the Contributing documentation hasn't been revised in a few years and so we'll probably provide more specific feedback than is in those docs, we're kinda playing catchup after stalling out due to some Typescript bugs blocking a proper implementation of data models.

@JPMeehan JPMeehan changed the title Version 12.330 Version 12.331 Aug 15, 2024
@kmoschcau
Copy link
Collaborator

@JPMeehan can you please add a remark to also update common/documents/_types.d.mts when updating any of these: BaseAmbientSound, BaseScene, BaseRegion and BaseRegionBehavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
foundry v12 This belongs to Foundry VTT version 12
Projects
None yet
Milestone
v12 Release
Development

No branches or pull requests
3 participants
@kmoschcau @JPMeehan @Abourass