Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look into the typing of Hooks.on #2906

Open
LukeAbby opened this issue Nov 1, 2024 · 1 comment
Open

Look into the typing of Hooks.on #2906

LukeAbby opened this issue Nov 1, 2024 · 1 comment
Assignees
@LukeAbby

Comments

@LukeAbby
Copy link
Collaborator

LukeAbby commented Nov 1, 2024

The typing is pretty close to ideal but especially the "dynamic callbacks" could be improved and ideally limits the usage of overrides.

Also SceneManager#registerHooks needs to match this type.
@LukeAbby LukeAbby self-assigned this Nov 1, 2024
@LukeAbby LukeAbby mentioned this issue Nov 1, 2024
Merged
@LukeAbby
Copy link
Collaborator Author

LukeAbby commented Nov 1, 2024

For example the hook preCreate${DocumentType} should correspond to a hook for that specific document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LukeAbby LukeAbby

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LukeAbby