fix(deps): Upgrades jscommons for Node 12 upgrade (LLC-22) (#692)

Author: cbishopvelti

package.json

@@ -54,7 +54,7 @@
     "http-status-codes": "^1.3.0",
     "install": "^0.13.0",
     "ioredis": "^4.14.0",
-    "jscommons": "^2.4.14",
+    "jscommons": "^3.0.0",
     "jsonwebtoken": "^8.5.1",
     "lodash": "^4.17.4",
     "mime-types": "2.1.27",

src/apps/activities/expressPresenter/postProfile.ts

@@ -7,7 +7,7 @@ import patchProfileWithService from './utils/patchProfileWithService';
 export default (config: Config) => {
   return catchErrors(config, async (req: Request, res: Response): Promise<void> => {
     const query = req.query;
-    const method = query.method;
+    const method = query.method as string | undefined;
 
     if (method !== undefined) {
       return alternateProfileRequest({ config, method, req, res });

src/apps/agents/expressPresenter/getFullAgent.ts

@@ -11,7 +11,7 @@ export default (config: Config) => {
   return catchErrors(config, async (req: Request, res: Response): Promise<void> => {
     const client = await getClient(config, req.header('Authorization'));
     validateVersionHeader(req.header('X-Experience-API-Version'));
-    const agent = getAgent(req.query.agent);
+    const agent = getAgent(req.query.agent as string | undefined);
     const result = await config.service.getFullAgent({ client, agent });
     res.status(OK);
     res.setHeader('X-Experience-API-Version', xapiHeaderVersion);

src/apps/agents/expressPresenter/postProfile.ts

@@ -7,7 +7,7 @@ import patchProfileWithService from './utils/patchProfileWithService';
 export default (config: Config) => {
   return catchErrors(config, async (req: Request, res: Response): Promise<void> => {
     const query = req.query;
-    const method = query.method;
+    const method = query.method as string | undefined;
 
     if (method !== undefined) {
       return alternateProfileRequest({ config, method, req, res });

src/apps/statements/expressPresenter/getFullActivity.ts

@@ -9,7 +9,7 @@ import validateHeaderVersion from './utils/validateHeaderVersion';
 export default (config: Config) => {
   return catchErrors(config, async (req: Request, res: Response): Promise<void> => {
     const client = await getClient(config, req.header('Authorization'));
-    const activityId = getActivityId(req.query.activityId);
+    const activityId = getActivityId(req.query.activityId as string | undefined);
 
     validateHeaderVersion(req.header('X-Experience-API-Version'));
 

src/apps/statements/expressPresenter/postStatements/index.ts

@@ -29,7 +29,7 @@ const parseJsonBody = async (config: Config, req: Request) => {
 export default (config: Config) => {
   return catchErrors(config, async (req: Request, res: Response): Promise<void> => {
 
-    const method = req.query.method;
+    const method = req.query.method as string | undefined;
     const contentType = defaultTo(req.header('Content-Type'), '');
 
     if (method === undefined && multipartContentTypePattern.test(contentType)) {

src/apps/states/expressPresenter/postState.ts

@@ -7,7 +7,7 @@ import patchStateWithService from './utils/patchStateWithService';
 export default (config: Config) => {
   return catchErrors(config, async (req: Request, res: Response): Promise<void> => {
     const query = req.query;
-    const method = query.method;
+    const method = query.method as string | undefined;
 
     if (method !== undefined) {
       return alternateStateRequest({ config, method, req, res });