fix(MongoDB): Avoid creating multiple instances of DB connection (LLC-2350) (#891)

Author: lucuilearningpool

src/apps/activities/mongoAuthRepo/tests/getClient.test.ts

@@ -49,7 +49,7 @@ const TEST_OAUTH_TOKEN = {
 };
 
 describe('getClient from mongo client', () => {
-  const connection = connectToMongoDb();
+  const connection = connectToMongoDb;
   const authRepo = mongoFactory({ db: connection });
 
   beforeEach(async () => {

src/apps/agents/mongoAuthRepo/tests/getClient.test.ts

@@ -49,7 +49,7 @@ const TEST_OAUTH_TOKEN = {
 };
 
 describe('getClient from mongo client', () => {
-  const connection = connectToMongoDb();
+  const connection = connectToMongoDb;
   const authRepo = mongoFactory({ db: connection });
 
   beforeEach(async () => {

src/apps/statements/repo/authRepo/getClient/mongo.test.ts

@@ -51,7 +51,7 @@ const TEST_OAUTH_TOKEN = {
 };
 
 describe(__filename, () => {
-  const connection = connectToMongoDb();
+  const connection = connectToMongoDb;
   const authRepo = mongoFactory({ db: connection });
 
   beforeEach(async () => {

src/apps/statements/repo/authRepo/utils/mongoAuth/factory.ts

@@ -6,7 +6,7 @@ import FactoryConfig from './FactoryConfig';
 
 export default (factoryConfig?: FactoryConfig): Facade => {
   const facadeConfig: FacadeConfig =
-    factoryConfig !== undefined ? factoryConfig : { db: connectToMongoDb() };
+    factoryConfig !== undefined ? factoryConfig : { db: connectToMongoDb };
   return {
     getClient: getClient(facadeConfig),
   };

src/apps/statements/repo/index.ts

@@ -10,7 +10,7 @@ export const repoFactoryConfig: RepoFactoryConfig = {
     facade: config.repoFactory.authRepoName,
     fake: {},
     mongo: {
-      db: connectToMongoDb(),
+      db: connectToMongoDb,
     },
   },
   events: {
@@ -24,7 +24,7 @@ export const repoFactoryConfig: RepoFactoryConfig = {
   models: {
     facade: config.repoFactory.modelsRepoName,
     mongo: {
-      db: connectToMongoDb(),
+      db: connectToMongoDb,
       maxTimeMs: config.defaultTimeout,
     },
   },

src/apps/statements/repo/modelsRepo/utils/mongoModels/factory.ts

@@ -24,7 +24,7 @@ export default (factoryConfig?: FactoryConfig): Facade => {
   const facadeConfig: FacadeConfig =
     factoryConfig !== undefined
       ? factoryConfig
-      : { db: connectToMongoDb(), maxTimeMs: defaultMaxTimeMs };
+      : { db: connectToMongoDb, maxTimeMs: defaultMaxTimeMs };
   return {
     clearRepo: async () => {
       await (await facadeConfig.db()).dropDatabase();

src/apps/statements/repo/utils/connectToMongoDb.ts

@@ -1,13 +1,12 @@
 import connectToDb from 'jscommons/dist/mongoRepo/utils/connectToDb';
 import { once } from 'lodash';
-import { Db } from 'mongodb';
 import config from '../../../../config';
 import logger from '../../../../logger';
 
-export default once((): (() => Promise<Db>) => {
-  return connectToDb({
+export default once(
+  connectToDb({
     dbName: config.mongoModelsRepo.dbName,
     logger,
     url: config.mongoModelsRepo.url,
-  });
-});
+  }),
+);

src/apps/statements/tests/getStatements/cursorDifferentStoredValues.test.ts

@@ -61,7 +61,7 @@ describe('get statements with different stored value using cursor', () => {
   );
 
   it('should return correct statements when ascending', async () => {
-    const db = await connectToMongoDb()();
+    const db = await connectToMongoDb();
     await db
       .collection('statements')
       .insertMany([statement1, statement2, statement3, statement4, statement5]);
@@ -94,7 +94,7 @@ describe('get statements with different stored value using cursor', () => {
   });
 
   it('should return correct statements when descending cursor', async () => {
-    const db = await connectToMongoDb()();
+    const db = await connectToMongoDb();
     await db
       .collection('statements')
       .insertMany([statement1, statement2, statement3, statement4, statement5]);

src/apps/states/mongoAuthRepo/tests/getClient.test.ts

@@ -49,7 +49,7 @@ const TEST_OAUTH_TOKEN = {
 };
 
 describe(__filename, () => {
-  const connection = connectToMongoDb();
+  const connection = connectToMongoDb;
   const authRepo = mongoFactory({ db: connection });
 
   beforeEach(async () => {

src/conformanceServer.ts

@@ -37,7 +37,7 @@ const testClient = {
 };
 
 (async () => {
-  const db = await connectToMongoDb()();
+  const db = await connectToMongoDb();
   console.info('Dropping database for ADL conformance tests.');
   await db.dropDatabase();
   console.info('Seeding database for ADL conformance tests.');