Skip to content
This repository has been archived by the owner on Oct 28, 2020. It is now read-only.

User Deprecated Symfony 4.0 #101

Open
allfreelancers opened this issue Feb 15, 2018 · 8 comments
Open

User Deprecated Symfony 4.0 #101

allfreelancers opened this issue Feb 15, 2018 · 8 comments

Comments

@allfreelancers
Copy link

User Deprecated: Implementing "Symfony\Component\HttpKernel\DataCollector\DataCollectorInterface" without the "reset()" method is deprecated since Symfony 3.4 and will be unsupported in 4.0 for class "Lsw\MemcacheBundle\DataCollector\MemcacheDataCollector".

@mevdschee
Copy link
Contributor

Good find, thank you. What do you propose? Can you do a PR?

@allfreelancers
Copy link
Author

@mevdschee What does PR mean?

@mevdschee
Copy link
Contributor

@allfreelancers ... sorry about the acronym.. I meant a Pull Request.

@allfreelancers
Copy link
Author

allfreelancers commented Feb 15, 2018

@mevdschee ok, a little later I will do

@GabrielAnca
Copy link
Contributor

GabrielAnca commented Feb 15, 2018

Hi @allfreelancers. We would be very happy if you want to contribute about this issue. You can use these two pull requests as reference, they fixed the same issue in other of our bundles:

Best regards

@allfreelancers
Copy link
Author

allfreelancers commented Feb 19, 2018

@GabrielAnca, in Lsw\MemcacheBundle\DataCollector\MemcacheDataCollector we can add this?

public function reset()
{
  $this->data = [];
}

@GabrielAnca
Copy link
Contributor

Hi @allfreelancers, if you do that, it will most likely remove the warnings.

Please use array() instead of [] to keep backwards compatibility :)

@tobias-93
Copy link

For anyone looking for a Symfony 4 compatible version of this bundle: I have forked the bundle and applied the patches necessary for Symfony 4 here: https://github.com/Kick-In/LswMemcacheBundle. Use "kick-in/memcache-bundle": "~v3.0" as composer constraint.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants