Fixed examples and container improvements #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed broken examples and tests. Fixed documentation. Replaced containers number_of_traces attributes by __len__ implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes broken examples due to recent breaking changes.
It also replaces the
number_of_tracesattributes by implementing the__len__method in each container class, which is more pythonic.Finally, as modifying
number_of_tracescould be used to limit the number of traces for an analysis, this must now be done by using the new classSlicewhich wraps an existing container. Any container hassliced(start, stop)andlimited(count)shortcut methods to wrap the container in aSlice.