diff --git a/CHANGELOG.md b/CHANGELOG.md index 5478431d9..160a7b46e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 Dates are in `dd-mm-yyyy` format. +## [2.2.2] - 08-04-2024 + +### Added + +- During wallet policy registration, the app will recognize and explicitly label as `dummy` any extended public key whose compressed pubkey is `0250929b74c1a04954b78b4b6035e97a5e078a5a0f28ec96d547bfee9ace803ac0`. This is useful especially for taproot miniscript policies which do not intend to use keypath spending. + +### Changed + +- Message signing: will now show the full text of the message, instead of its hash. If the message is too long (over 640 characters) or it contains non-printable characters (not in the range `0x20..0x70`, inclusive), then the SHA256 hash will be shown, as in previous versions of the app. +- Transaction signing: changed the wording to make the ux slightly simpler and clearer. + ## [2.2.1] - 18-03-2024 ### Fixed diff --git a/Makefile b/Makefile index 58dd91fcd..42b6daa5a 100644 --- a/Makefile +++ b/Makefile @@ -1,6 +1,6 @@ # **************************************************************************** # Ledger App for Bitcoin -# (c) 2023 Ledger SAS. +# (c) 2024 Ledger SAS. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. @@ -47,7 +47,7 @@ PATH_SLIP21_APP_LOAD_PARAMS = "LEDGER-Wallet policy" # Application version APPVERSION_M = 2 APPVERSION_N = 2 -APPVERSION_P = 1 +APPVERSION_P = 2 APPVERSION_SUFFIX = # if not empty, appended at the end. Do not add a dash. ifeq ($(APPVERSION_SUFFIX),) diff --git a/src/boilerplate/apdu_parser.c b/src/boilerplate/apdu_parser.c index b63c5b686..8304d1aac 100644 --- a/src/boilerplate/apdu_parser.c +++ b/src/boilerplate/apdu_parser.c @@ -1,6 +1,6 @@ /***************************************************************************** * Ledger App Bitcoin. - * (c) 2021 Ledger SAS. + * (c) 2024 Ledger SAS. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. diff --git a/src/boilerplate/dispatcher.c b/src/boilerplate/dispatcher.c index ef8b864ee..7c760cbce 100644 --- a/src/boilerplate/dispatcher.c +++ b/src/boilerplate/dispatcher.c @@ -1,6 +1,6 @@ /***************************************************************************** * Ledger App Bitcoin. - * (c) 2021 Ledger SAS. + * (c) 2024 Ledger SAS. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. diff --git a/src/boilerplate/io.c b/src/boilerplate/io.c index edac0d3c4..d70100413 100644 --- a/src/boilerplate/io.c +++ b/src/boilerplate/io.c @@ -1,6 +1,6 @@ /***************************************************************************** * Ledger App Bitcoin. - * (c) 2021 Ledger SAS. + * (c) 2024 Ledger SAS. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. diff --git a/src/common/base58.c b/src/common/base58.c index bd52d49f7..19931d8cf 100644 --- a/src/common/base58.c +++ b/src/common/base58.c @@ -1,5 +1,5 @@ /***************************************************************************** - * (c) 2021 Ledger SAS. + * (c) 2024 Ledger SAS. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. diff --git a/src/common/bip32.c b/src/common/bip32.c index e86580891..daf94579e 100644 --- a/src/common/bip32.c +++ b/src/common/bip32.c @@ -1,5 +1,5 @@ /***************************************************************************** - * (c) 2020 Ledger SAS. + * (c) 2024 Ledger SAS. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. diff --git a/src/common/buffer.c b/src/common/buffer.c index 9f1679f72..afed26e4f 100644 --- a/src/common/buffer.c +++ b/src/common/buffer.c @@ -1,5 +1,5 @@ /***************************************************************************** - * (c) 2021 Ledger SAS. + * (c) 2024 Ledger SAS. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. diff --git a/src/common/format.c b/src/common/format.c index bf301f9dd..49ad9dac5 100644 --- a/src/common/format.c +++ b/src/common/format.c @@ -1,5 +1,5 @@ /***************************************************************************** - * (c) 2021 Ledger SAS. + * (c) 2024 Ledger SAS. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. diff --git a/src/common/merkle.c b/src/common/merkle.c index ea9d7d4e2..65f5e2baf 100644 --- a/src/common/merkle.c +++ b/src/common/merkle.c @@ -1,6 +1,6 @@ /***************************************************************************** * Ledger App Bitcoin. - * (c) 2021 Ledger SAS. + * (c) 2024 Ledger SAS. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. diff --git a/src/common/read.c b/src/common/read.c index 71e2594fe..6c467c1f6 100644 --- a/src/common/read.c +++ b/src/common/read.c @@ -1,5 +1,5 @@ /***************************************************************************** - * (c) 2021 Ledger SAS. + * (c) 2024 Ledger SAS. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. diff --git a/src/common/varint.c b/src/common/varint.c index cc67a3f79..a4ade88b3 100644 --- a/src/common/varint.c +++ b/src/common/varint.c @@ -1,5 +1,5 @@ /***************************************************************************** - * (c) 2021 Ledger SAS. + * (c) 2024 Ledger SAS. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. diff --git a/src/common/write.c b/src/common/write.c index 34d78ae98..824e69e9a 100644 --- a/src/common/write.c +++ b/src/common/write.c @@ -1,5 +1,5 @@ /***************************************************************************** - * (c) 2021 Ledger SAS. + * (c) 2024 Ledger SAS. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. diff --git a/src/crypto.c b/src/crypto.c index 7f376add4..a3ba37282 100644 --- a/src/crypto.c +++ b/src/crypto.c @@ -1,6 +1,6 @@ /***************************************************************************** * Ledger App Bitcoin. - * (c) 2021 Ledger SAS. + * (c) 2024 Ledger SAS. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. diff --git a/src/handler/get_extended_pubkey.c b/src/handler/get_extended_pubkey.c index 6dc746a42..536d247ea 100644 --- a/src/handler/get_extended_pubkey.c +++ b/src/handler/get_extended_pubkey.c @@ -1,6 +1,6 @@ /***************************************************************************** * Ledger App Bitcoin. - * (c) 2021 Ledger SAS. + * (c) 2024 Ledger SAS. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. diff --git a/src/handler/get_master_fingerprint.c b/src/handler/get_master_fingerprint.c index 49ed912a9..e1993c390 100644 --- a/src/handler/get_master_fingerprint.c +++ b/src/handler/get_master_fingerprint.c @@ -1,6 +1,6 @@ /***************************************************************************** * Ledger App Bitcoin. - * (c) 2021 Ledger SAS. + * (c) 2024 Ledger SAS. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. diff --git a/src/handler/get_wallet_address.c b/src/handler/get_wallet_address.c index 6e12f7711..96a6cbdb1 100644 --- a/src/handler/get_wallet_address.c +++ b/src/handler/get_wallet_address.c @@ -1,6 +1,6 @@ /***************************************************************************** * Ledger App Bitcoin. - * (c) 2021 Ledger SAS. + * (c) 2024 Ledger SAS. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. diff --git a/src/handler/register_wallet.c b/src/handler/register_wallet.c index 21b1ec9b3..3aea4d54c 100644 --- a/src/handler/register_wallet.c +++ b/src/handler/register_wallet.c @@ -1,6 +1,6 @@ /***************************************************************************** * Ledger App Bitcoin. - * (c) 2021 Ledger SAS. + * (c) 2024 Ledger SAS. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. diff --git a/src/handler/sign_message.c b/src/handler/sign_message.c index 9efe2147d..b5b0fe262 100644 --- a/src/handler/sign_message.c +++ b/src/handler/sign_message.c @@ -1,6 +1,6 @@ /***************************************************************************** * Ledger App Bitcoin. - * (c) 2021 Ledger SAS. + * (c) 2024 Ledger SAS. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. diff --git a/src/handler/sign_psbt.c b/src/handler/sign_psbt.c index f4d1c998d..25839210b 100644 --- a/src/handler/sign_psbt.c +++ b/src/handler/sign_psbt.c @@ -1,6 +1,6 @@ /***************************************************************************** * Ledger App Bitcoin. - * (c) 2021 Ledger SAS. + * (c) 2024 Ledger SAS. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. diff --git a/src/main.c b/src/main.c index c655364f9..0d1760914 100644 --- a/src/main.c +++ b/src/main.c @@ -1,6 +1,6 @@ /***************************************************************************** * Ledger App Bitcoin. - * (c) 2021 Ledger SAS. + * (c) 2024 Ledger SAS. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. diff --git a/src/ui/menu.c b/src/ui/menu.c index 88925e5e0..78b8dfb0d 100644 --- a/src/ui/menu.c +++ b/src/ui/menu.c @@ -1,6 +1,6 @@ /***************************************************************************** * Ledger App Bitcoin. - * (c) 2021 Ledger SAS. + * (c) 2024 Ledger SAS. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. diff --git a/src/ui/menu_bagl.c b/src/ui/menu_bagl.c index b0f1b835e..ee617973c 100644 --- a/src/ui/menu_bagl.c +++ b/src/ui/menu_bagl.c @@ -1,6 +1,6 @@ /***************************************************************************** * Ledger App Bitcoin. - * (c) 2021 Ledger SAS. + * (c) 2024 Ledger SAS. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -57,7 +57,7 @@ UX_FLOW(ux_menu_main_flow_bitcoin_testnet, &ux_menu_exit_step, FLOW_LOOP); -UX_STEP_NOCB(ux_menu_info_step, bn, {"Bitcoin App", "(c) 2023 Ledger"}); +UX_STEP_NOCB(ux_menu_info_step, bn, {"Bitcoin App", "(c) 2024 Ledger"}); UX_STEP_CB(ux_menu_back_step, pb, ui_menu_main(), {&C_icon_back, "Back"}); // FLOW for the about submenu: diff --git a/src/ui/menu_nbgl.c b/src/ui/menu_nbgl.c index 562d47c72..4473a89bb 100644 --- a/src/ui/menu_nbgl.c +++ b/src/ui/menu_nbgl.c @@ -1,6 +1,6 @@ /***************************************************************************** * Ledger App Bitcoin. - * (c) 2021 Ledger SAS. + * (c) 2024 Ledger SAS. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -22,7 +22,7 @@ #include "menu.h" static const char* const infoTypes[] = {"Version", "Developer", "Copyright"}; -static const char* const infoContents[] = {APPVERSION, "Ledger", "(c) 2023 Ledger"}; +static const char* const infoContents[] = {APPVERSION, "Ledger", "(c) 2024 Ledger"}; static bool navigation_cb(uint8_t page, nbgl_pageContent_t* content) { UNUSED(page); diff --git a/tests/snapshots/nanos/test_dashboard/00001.png b/tests/snapshots/nanos/test_dashboard/00001.png index ce7265a6e..4f6fca92d 100644 Binary files a/tests/snapshots/nanos/test_dashboard/00001.png and b/tests/snapshots/nanos/test_dashboard/00001.png differ diff --git a/tests/snapshots/nanosp/test_dashboard/00001.png b/tests/snapshots/nanosp/test_dashboard/00001.png index 782cb782c..e809f8d13 100644 Binary files a/tests/snapshots/nanosp/test_dashboard/00001.png and b/tests/snapshots/nanosp/test_dashboard/00001.png differ diff --git a/tests/snapshots/nanox/test_dashboard/00001.png b/tests/snapshots/nanox/test_dashboard/00001.png index 782cb782c..e809f8d13 100644 Binary files a/tests/snapshots/nanox/test_dashboard/00001.png and b/tests/snapshots/nanox/test_dashboard/00001.png differ diff --git a/tests/snapshots/stax/test_dashboard/00001.png b/tests/snapshots/stax/test_dashboard/00001.png index d81182554..8bbb4978e 100644 Binary files a/tests/snapshots/stax/test_dashboard/00001.png and b/tests/snapshots/stax/test_dashboard/00001.png differ