Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🔧 Upgrade Electron to v32 #7791

Closed
wants to merge 1 commit into from

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Sep 11, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Non reg test when release

📝 Description

Upgrade Electron 30 to 32

No breaking changes that impact our stack

Release notes :

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Sep 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 2:15pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 2:15pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 2:15pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 2:15pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 2:15pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Sep 11, 2024
@mcayuelas-ledger mcayuelas-ledger changed the title chore: 🔧 Update Electron to v32 chore: 🔧 Upgrade Electron to v32 Sep 11, 2024
Copy link

socket-security bot commented Sep 11, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/[email protected]

View full report↗︎

@live-github-bot
Copy link
Contributor

live-github-bot bot commented Sep 11, 2024

Desktop Bundle Checks

Comparing 107a618 against 9ae8724.

⚠️ main bundle size significantly increased: 1.7mb -> 2mb. Please check if this is expected.
⚠️ @sentry/utils library is now duplicated in main (regression)
⚠️ @sentry/core library is now duplicated in main (regression)
⚠️ @sentry/opentelemetry library is now duplicated in main (regression)
⚠️ opentelemetry-instrumentation-fetch-node library is now duplicated in main (regression)
⚠️ @opentelemetry/instrumentation-express library is now duplicated in main (regression)
⚠️ @opentelemetry/instrumentation-fastify library is now duplicated in main (regression)
⚠️ @opentelemetry/instrumentation-graphql library is now duplicated in main (regression)
⚠️ @opentelemetry/instrumentation-mongodb library is now duplicated in main (regression)
⚠️ @opentelemetry/instrumentation-mongoose library is now duplicated in main (regression)
⚠️ @opentelemetry/instrumentation-mysql library is now duplicated in main (regression)
⚠️ @opentelemetry/instrumentation-mysql2 library is now duplicated in main (regression)
⚠️ @opentelemetry/instrumentation-ioredis library is now duplicated in main (regression)
⚠️ @opentelemetry/instrumentation-redis-4 library is now duplicated in main (regression)
⚠️ @opentelemetry/instrumentation-nestjs-core library is now duplicated in main (regression)
⚠️ @opentelemetry/instrumentation-pg library is now duplicated in main (regression)
⚠️ @prisma/instrumentation library is now duplicated in main (regression)
⚠️ @opentelemetry/instrumentation-hapi library is now duplicated in main (regression)
⚠️ @opentelemetry/instrumentation-koa library is now duplicated in main (regression)
⚠️ @opentelemetry/instrumentation-connect library is now duplicated in main (regression)
⚠️ @sentry/node library is now duplicated in main (regression)

Mobile Bundle Checks

Comparing 0fcd24f against 4128cce.

🚀 main.ios.jsbundle bundle size decreased (64.5mb -> 64.4mb). Thanks ❤️
🚀 main.android.jsbundle bundle size decreased (64.5mb -> 64.4mb). Thanks ❤️

@mcayuelas-ledger mcayuelas-ledger force-pushed the chore/electron-32 branch 2 times, most recently from 555445b to 35a35c4 Compare September 11, 2024 12:25
@mcayuelas-ledger mcayuelas-ledger requested review from KVNLS and a team September 11, 2024 12:56
@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Sep 11, 2024
@live-github-bot live-github-bot bot removed the mobile Has changes in LLM label Sep 11, 2024
@mcayuelas-ledger mcayuelas-ledger force-pushed the chore/electron-32 branch 2 times, most recently from dab00e0 to c9a4314 Compare September 11, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant