Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

Show amount of tokens and actual destination address when sending ERC-20 tokens #64

Open
john-light opened this issue Dec 15, 2019 · 2 comments

Comments

@john-light
Copy link

I recently sent DAI using a Ledger account, and when I was prompted to sign the tx using my Ledger Nano S, the default confirmation screen showed essentially no useful information aside from the max fee I was paying. The send amount was shown as "0 ETH" and "Send to" address was shown as the DAI contract address rather than the actual destination address I was sending to.

If I turn on "Display data" then one of the parameter fields on the confirmation screen does show the actual destination address I'm sending to, however this is not very user friendly since it just says "Parameter" rather than "Send to" or something like that. And even with "Display data" turned on, the actual token amount that I'm sending (e.g. 100 DAI) still isn't shown on the screen.

@toonsevrin
Copy link

$8M was lost by the CEO of Nexus Mutual due to hackers installing a malicious MetaMask on his device. All though he was using a hardware wallet, it didn't show the destination/amount because the display did not have ERC20 support. If this issue was resolved the CEO would still have his tokens today. I hope this adds some incentive to implement the amount+destination for ERC20 compliant contracts.

@sdherr
Copy link

sdherr commented Dec 10, 2021

I would like to add my +1 here. It is extremely disconcerting to have the "address" shown not be the expected destination address.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants