Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize support for external providers #13

Open
glethuillier opened this issue Feb 25, 2021 · 0 comments
Open

Generalize support for external providers #13

glethuillier opened this issue Feb 25, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@glethuillier
Copy link
Contributor

glethuillier commented Feb 25, 2021

The tool only handles two specific external providers: a default (free) one, and a custom (paid) one.

The implementation could be improved by generalizing the support for external providers. Notably, a more robust way of transforming the raw responses into raw transaction and transaction models could be suggested.

Here are some possible checks:

  • Ensure that the API key is valid (i.e. perform one request and check that there is no authorization issue before running the full scan)
  • Validate the contents of the response: is it the expected structure? Are the types valid?

Refactor the code to have some kind of dispatcher to select the relevant provider.

Note that the requests underlying implementation should be improved beforehand.

In this context, see also: #7 (review)

@glethuillier glethuillier added the enhancement New feature or request label Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant