Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scanning fails due to axios minor update breaking api #149

Open
losh11 opened this issue Jan 14, 2023 · 3 comments
Open

Scanning fails due to axios minor update breaking api #149

losh11 opened this issue Jan 14, 2023 · 3 comments

Comments

@losh11
Copy link

losh11 commented Jan 14, 2023

The latest minor version of Axios has made a change requiring 'Accept-Encoding': 'application/json' to be sent in the header of a axios reqest with json response, otherwise the response is broken. When broken, it fails to scan addresses for balances. NPM auto updates to this version unfortunately.

Requires adding the addtional header to here: https://github.com/LedgerHQ/xpub-scan/blob/main/src/helpers.ts#L25

@njmurarka
Copy link

Was this ever resolved? I am getting errors too that might be related, due to Axios.

@losh11
Copy link
Author

losh11 commented Mar 11, 2023

Not as far as I know. But the fix is really simple, so I'd just add it in as a patch...

@njmurarka
Copy link

Would greatly appreciate that or a PR. I can just grab it and run it. Not sure why this issue has sat around this long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants