[BE] 전시현 로그인 #5
Open
[BE] 전시현 로그인 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootTiket
reviewed
May 16, 2024
|
|
||
| private String makeToken(Date expiry, User user) { | ||
| Date now = new Date(); | ||
| String encodedEmail = Base64.getEncoder().encodeToString(user.getEmail().getBytes()); |
There was a problem hiding this comment.
해당 오류는 base64를 인코딩하는 과정에서 발생하는 문제 같습니다.
base64에서 원칙적으로 사용하지 않는 문자를 인코딩 과정에서 포함될 경우 해당 오류가 나타날 수 있습니다.
safeencoding을 사용하면 위와 같은 문제를 해결 할 수 있을 것 같습니다!
String encodedEmail = Base64.getUrlEncoder().encodeToString(user.getEmail().getBytes());참고해주세요
rootTiket
reviewed
May 16, 2024
src/main/resources/application.yml
Outdated
Comment on lines
21
to
25
| issuer: [email protected] | ||
| secret_key: study-springboot | ||
| header: Authorization | ||
| secret: 57e28d84f356b2af66d4fbd5d38efece93455f1b0fac02a28f4be437d9172462 | ||
| token-validity-in-seconds: 86400 |
There was a problem hiding this comment.
key는 환경변수로 따로 관리해주는게 좋을것 같습니다!
src/main/resources/application.yml
Outdated
Comment on lines
6
to
9
| url: jdbc:h2:mem:testdb | ||
| MODE: MySQL | ||
| username: sa | ||
| generate-unique-name: false |
There was a problem hiding this comment.
이번에는 h2를 사용했는데 로컬에서 mysql사용해보는걸 연습해보는건 어떨까요?
추후 프로젝트에서 로컬 db를 사용하게 될 때 mysql을 많이 사용해서 적용해보시면 좋을 것 같습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
미션 실행 실패 케이스 존재 시, 실패한 이유 고찰해보기
token을 생성하는 부분에서 오류가 난 거 같습니다
로그인 부분은 구현 했지만 attend하는 부분은 실행이 안됩니다