[BE] 이지훈 로그인 #9
Open
[BE] 이지훈 로그인 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyxklee
reviewed
May 30, 2024
| UsernamePasswordAuthenticationToken usernamePasswordAuthenticationToken = new UsernamePasswordAuthenticationToken( | ||
| userDetails, null, userDetails.getAuthorities()); | ||
| usernamePasswordAuthenticationToken.setDetails(new WebAuthenticationDetailsSource().buildDetails(request)); | ||
| SecurityContextHolder.getContext().setAuthentication(usernamePasswordAuthenticationToken); |
There was a problem hiding this comment.
UsernamePasswordAuthenticationToken을 이용해서 유저 인증을 하는 로직을 필터가 아니라 서비스 단에서 Login() 메소드안에 구현해보는건 어떨까요?
| http.authorizeHttpRequests((authorize) -> authorize. | ||
| requestMatchers("/**").permitAll() | ||
| .anyRequest().permitAll()); | ||
|
|
There was a problem hiding this comment.
현재 모든 경로가 permitAll()로 열려있는거 같아요! 요구사항에 맞게 사용자 인증이 필요한 요청에는 인증이 요구되게 변경해주시면 좋을 거 같아요!
There was a problem hiding this comment.
2024-05-30 20:58 경로 login, register 사용자 허용 수정했습니다 !
| try { | ||
| authenticationManager.authenticate( | ||
| new UsernamePasswordAuthenticationToken(authRequest.getUsername(), authRequest.getPassword()) | ||
| ); |
There was a problem hiding this comment.
마찬가지로 컨트롤러에서 인증하는 로직이 돌아가는 것 보단 서비스 단에서 돌아가는게 어떨까요?
| import jakarta.persistence.GeneratedValue; | ||
| import jakarta.persistence.GenerationType; | ||
| import jakarta.persistence.Id; | ||
|
|
There was a problem hiding this comment.
Lombok의 어노테이션을 사용하면 코드가 간략해져서 추천 드려요!
| @@ -0,0 +1,2 @@ | |||
| package dto;public class Registerrequest { | |||
There was a problem hiding this comment.
DTO명을 request와 response로 작성하신건 좋은 거 같아요!
| import java.util.Optional; | ||
|
|
||
| public interface UserRepository extends JpaRepository<User, Long> { | ||
| Optional<User> findByUsername(String username); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
미완성 PR입니다 :(