-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discussion: Ready for 1.0? #70
Comments
For me sticky indices is still quite needed feature, will try to take a look at it over the weekend to asses how big it is. I also wanted to solve #53, but it looks tricky and I still can not find proper solution to it. Overall I would like more manual test cases, for example for viewability, various element sizes etc. Just want to be sure library is usable before releasing 1.0.0 version. |
Sticky indices would be a great feature! But I think it could come after 1.0? There's lots of people who don't need it, so we can get this to them without it. We can just explicitly call out in the docs that it's not supported yet and is actively being worked on. Looking at your PR it seems like it's a pretty big feature... Can you share more about the problem that #53 is trying to solve in that thread? I'm not 100% sure what it is - I think it's that when pulling the top to refresh the top item flashes when the new items come in? Maybe I can give it an attempt or throw out some ideas. Maybe we can launch in the current state as 1.0 beta and ask people to try it, add more example test cases, and share any issues they find? I agree that I'm not 100% sure everything is perfect yet, so maybe more community attention/feedback is the best way to go? |
It was surprisingly easy to hack together, but yeah, making it production ready feature would take a while. I had to convert from FlowType and patch ScrollViewStickyHeader from React Native codebase. Checking that it's backward compatible with other version of RN and web probably would take a while. This should not be blocker for 1.0.0 release
Yes it's about those flashes when adding data to the top. We are using estimates to place unmeasured items, and in most cases it's not a problem when list is scrolling, because it's mostly unnoticeable, but when scroll is standing still it's perceived as a bug.
1.0.0 beta would be great idea, we can freeze all features for current main branch and focus on bug fixes. |
Unless I'm mistaken, part of the functionality from FlashList's overrideItemLayout is missing:
Emphasis mine. For example, in a calendar view, I have numColumns={7} for the days. However, I need the month headers to span all 7 columns, which I can do with the above FlashList prop. |
How are we looking for version 1.0? As of version 0.6.4 it seems like we're at a good level of performance, all features seem to be working well, and I have nothing left on my todo list.
Of course there's still potential for more performance optimization and more advanced features (masonry layout, etc...). But I think as long as we have better perf than alternatives and everything is stable, then we should go for 1.0 asap and build on it from there.
The text was updated successfully, but these errors were encountered: