Requirements

• Is this a bug report? For questions or discussions use https://lemmy.ml/c/lemmy_support
• Did you check to see if this issue already exists?
• Is this only a single bug? Do not put multiple bugs in one issue.
• Do you agree to follow the rules in our Code of Conduct?
• Is this a backend issue? Use the lemmy-ui repo for UI / frontend issues.

Summary

On instances with registration applications enabled, when a user changes their email address, an inappropriate new registration application email is sent to admins after the user has clicked the verification link.

Steps to Reproduce

Prerequisites:

• Instance must be configured to require an application
• Admin setting "Email admins on receiving new applications" must be enabled
• Setting to require email verification has no effect on the results (which is fine; changing email should require the new one to be verified before accepting it)

1. Have any user update their email address
2. User will receive a confirmation link to verify the new address
3. User clicks link and successfully verifies the new email address
4. Admins receive a non-applicable "{user who changed their email} has applied to join {instance}" notification email.

Technical Details

If that same function is called for both initial registration and email change, I would guess the issue is in verify_emai.rs as there doesn't seem to be any check besides whether admins should receive new registration notifications.

Version

BE 0.19.3

Lemmy Instance URL

No response