Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard blocked even for dev tools #394

Open
brauliodiez opened this issue Sep 22, 2024 · 0 comments
Open

Keyboard blocked even for dev tools #394

brauliodiez opened this issue Sep 22, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@brauliodiez
Copy link
Member

brauliodiez commented Sep 22, 2024

Maybe we are using a preventDefault when trapping the keyboard events?

Right now we got this

src/pods/canvas/use-keyboard-displacement.tsx

  useEffect(() => {
    const handleKeyDown = (event: KeyboardEvent) => {
      if (isInlineEditing) {
        return;
      }

      event.preventDefault();

      if (selectionInfo.selectedShapesIds.length === 0) {
        return;
      }

Since is keyboard displacement, we should only apply the prevent default on the keyboard command

@brauliodiez brauliodiez added the bug Something isn't working label Sep 22, 2024
brauliodiez added a commit that referenced this issue Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

1 participant