Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gate linear unit code seems wrong #1

Open
dragonrenaissance opened this issue Dec 29, 2020 · 2 comments
Open

gate linear unit code seems wrong #1

dragonrenaissance opened this issue Dec 29, 2020 · 2 comments
Assignees
@dragonrenaissance

Comments

@dragonrenaissance
Copy link 

    temp = self.conv1(X) + torch.sigmoid(self.conv2(X))

should be
temp = self.conv1(X) * torch.sigmoid(self.conv2(X))
@LeronQ
Copy link
Owner

LeronQ commented Dec 30, 2020

@dragonrenaissance Hi, you are right, the GLU should be self.conv1(X) * torch.sigmoid(self.conv2(X)). I will modify it

@xuhuabao
Copy link

not modify yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dragonrenaissance dragonrenaissance

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@LeronQ @xuhuabao @dragonrenaissance