Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getErrors function in DataSource interface #50

Open
solleer opened this issue Dec 21, 2017 · 2 comments
Open

getErrors function in DataSource interface #50

solleer opened this issue Dec 21, 2017 · 2 comments
Milestone
Version 1.0

Comments

@solleer
Copy link
Collaborator

solleer commented Dec 21, 2017

The getErrors function in the DataSource interface currently returns nothing but an empty array in all implementations of it. I feel like the implementations should be fixed or the function removed from the interface.
@solleer
Copy link
Collaborator Author

solleer commented Dec 22, 2017

Currently the function is not used by Maphper

@TRPB
Copy link
Member

TRPB commented Dec 22, 2017

Yes, you're right. It's probably best to let exceptions happen than to catch them and force them into an array

@TRPB TRPB closed this as completed Dec 22, 2017
@TRPB TRPB reopened this Dec 22, 2017
@solleer solleer added this to the Version 1.0 milestone Dec 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 1.0
Development

No branches or pull requests
2 participants
@TRPB @solleer