Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test assertions are backwards #6

Open
ScottFreeCode opened this issue Feb 24, 2016 · 0 comments
Open

Unit test assertions are backwards #6

ScottFreeCode opened this issue Feb 24, 2016 · 0 comments

Comments

@ScottFreeCode
Copy link
Contributor

According to http://api.qunitjs.com/equal/, the first argument should be the result of the test's processing and the second one should be the expected result. Looks like the tests are all backwards, meaning if they fail they'll label the expected result the actual result and the actual result the expected result, which could be confusing.

(Note that pull requests #3 and #5 add some tests, but do not address this issue.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant