Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify a custom prebuilds location #57

Closed
Azarattum opened this issue Dec 3, 2022 · 2 comments
Closed

Specify a custom prebuilds location #57

Azarattum opened this issue Dec 3, 2022 · 2 comments
Labels
more information needed Further information is requested stale This issue or pull request is old

Comments

@Azarattum
Copy link

Azarattum commented Dec 3, 2022 •
edited
Loading

My application is bundled for production use without node_modules installed. Currently classic-level looks for the binaries either in node_modules or in ./prebuilds (as far as I know). It would be nice to be able to specify a custom path upon initialization (e.g. as a config option).
@vweevers
Copy link
Member

vweevers commented Dec 3, 2022

That's possible if we lazily require() the binding. But I'm not sure it's worth it, because an (IMO) reasonable workaround already exists (copying to ./node_modules/classic-level/prebuilds or to ./prebuilds). Either way the prebuilds have to live somewhere on disk, so why not there?

@vweevers
Copy link
Member

vweevers commented Dec 3, 2022

Relevant: prebuild/prebuildify#57

@vweevers vweevers added the more information needed Further information is requested label Feb 10, 2023
@vweevers vweevers added the stale This issue or pull request is old label Feb 3, 2024
@vweevers vweevers closed this as not planned Won't fix, can't repro, duplicate, stale Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
more information needed Further information is requested stale This issue or pull request is old
Projects
Level
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vweevers @Azarattum