Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider vocabulary mappings in filter conditions #257

Open
hartig opened this issue Nov 24, 2022 · 2 comments
Open

Consider vocabulary mappings in filter conditions #257

hartig opened this issue Nov 24, 2022 · 2 comments

Comments

@hartig
Copy link
Member

hartig commented Nov 24, 2022 •
edited
Loading

Currently, when applying vocabulary mappings, filter expressions are ignored (see around line 86 in ApplyVocabularyMappings (after merging PR #256). This issue now is is about, first, defining and, second, implementing an approach to deal with vocabulary mappings in the context of filter conditions.
@hartig hartig mentioned this issue Nov 24, 2022
Merged
@hartig hartig mentioned this issue Dec 25, 2022
Open
@hartig
Copy link
Member Author

hartig commented Dec 25, 2022

Once this issue has been addressed, #271 would be a follow-up issue to be addressed.

@hartig
Copy link
Member Author

hartig commented Apr 25, 2023

Additionally, translateExpressions in VocabularyMappingUtils needs to be implemented as well.

hartig added a commit that referenced this issue Apr 25, 2023
@hartig
fixes bug: vocab.mapping-based rewriting of query pattern should not …
8efde46 
…fail if there is a FILTER inside the pattern! (applying the vocab.mapping to such a FILTER is a different thing, captured by #257)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hartig