Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing path in verifier message for payload directory #123

Open
rvanheest opened this issue Jul 12, 2018 · 3 comments · May be fixed by #125
Open

missing path in verifier message for payload directory #123

rvanheest opened this issue Jul 12, 2018 · 3 comments · May be fixed by #125

Comments

@rvanheest
Copy link

In MandatoryVerifier.checkPayloadDirectoryExists, when the bag/data directory does not exist, it returns "File [{}] should exist but it doesn't!". The path does not seemed to be filled in correctly.

@jscancella
Copy link
Contributor

@acdha line

throw new MissingPayloadDirectoryException(messages.getString("file_should_exist_error"));
should be
throw new MissingPayloadDirectoryException(messages.getString("file_should_exist_error"), dataDir);

@rvanheest
Copy link
Author

@jscancella shouldn't it also do something with MessageFormatter.format. I now see that in other places in that class as well...

@jscancella
Copy link
Contributor

@rvanheest yes, sorry that's what I get for replying too quickly. I had it in my head it was the logger, not an exception.

@jscancella jscancella linked a pull request Jul 22, 2018 that will close this issue
rvanheest pushed a commit to DANS-KNAW/dans-bagit-lib that referenced this issue Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants