Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests fails during dailight saving change period #451

Open
hakito opened this issue Nov 2, 2024 · 0 comments
Open

Unit tests fails during dailight saving change period #451

hakito opened this issue Nov 2, 2024 · 0 comments

Comments

@hakito
Copy link
Contributor

hakito commented Nov 2, 2024

The test ScheduleTotalConcurrentReservationsRuleTest::testChecksEachInstanceOfASeries fails on 2nd November 2024.

The reason seems to be that on line

$dates = $repeatOptions->GetDates($this->CurrentInstance()->Duration()->ToTimezone($this->_bookedBy->Timezone));

the calculated dates are calculated for the time zone of the 'booker' which is New York.

The DateRange class or Date seems to have timezone based conversions, but something must go wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant