fix: notify when the notification time is greater than or equal to interval

Signed-off-by: Vitor Mattos <[email protected]>

Author: vitormattos

lib/Service/ReminderService.php

@@ -197,7 +197,7 @@ private function isMaxReached(int $total, int $max): bool {
 
 	private function shouldNotifyAfterSomeDays(?\DateTime $date, \DateTime $now, int $maxDays): bool {
 		$daysAfter = $date?->diff($now)?->days ?? 0;
-		return $daysAfter > $maxDays;
+		return $maxDays > 0 && $daysAfter >= $maxDays;
 	}
 
 	protected function getNotificationsSummarized(array $notifications): array {

tests/php/Unit/Service/ReminderServiceTest.php

@@ -166,11 +166,11 @@ public static function providerWillNotify(): array {
 			],
 			'one notification, scheduled for yesterday, between = 1' => [
 				[
-					'first' => (clone $now)->modify('-1 day'),
-					'last' => (clone $now)->modify('-1 day'),
+					'first' => (clone $now)->modify('-1 day')->setTime(11, 0),
+					'last' => (clone $now)->modify('-1 day')->setTime(11, 0),
 					'total' => 1,
 				],
-				'now' => $now, 'daysBefore' => 1, 'daysBetween' => 1, 'max' => 5, false,
+				'now' => $now, 'daysBefore' => 1, 'daysBetween' => 1, 'max' => 5, true,
 			],
 			'one notification, should send' => [
 				[