Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] merge multiple overlapping control points #5

Closed
VanessaE opened this issue Apr 24, 2020 · 5 comments
Closed

[FR] merge multiple overlapping control points #5

VanessaE opened this issue Apr 24, 2020 · 5 comments

Comments

@VanessaE
Copy link

At present, the "merge ends" in this plugin can merge overlapping end points in a way similar to merging vertexes in a mesh... but it can only do one pair at a time. Trying to do this on an entire set of curves just throws "invalid selection".

The plugin really should just pair-off all endpoints that it can from that which is selected (silently ignoring selected handles of course, so that one could just do the entire object at once)

@Lichtso
Copy link
Owner

Lichtso commented Apr 24, 2020

Ok, I changed it so that the user selects the entire splines (e.g. by using select linked) and the tool then merges their ends based on their distance up to a maximum distance threshold parameter.

@VanessaE
Copy link
Author

yay 😃

@VanessaE VanessaE reopened this Apr 24, 2020
@VanessaE
Copy link
Author

VanessaE commented Apr 24, 2020

OOps, nope, still not working quite right. Consider this model:

Covid19 Face Shield Hole Punch V1.1.DXF.zip

(original source: https://grabcad.com/library/covid19-face-shield-hole-punch-v1-1-1 )

Import this DXF, switch the curve to 2D, go into edit mode and convert the whole thing to bezier splines, select all control points, and merge.

The model... um, kinda turns to mush 😃, or it'll throw this error (I'm not sure why the behavior varies):

image

@Lichtso
Copy link
Owner

Lichtso commented Apr 24, 2020

I think I fixed the bugs, as I can now import your model and merge everything correctly.

Three more tips, before merging the control points:

  • Go into the data properties of the curve and select Shape '2D', as well as, Fill Mode 'Both'. That way you can easily tell if everything worked afterwards.
  • Increase Geometry Extrude to add some depth to it.
  • Select everything and set Spline Type 'Bezier' because there are some 'Poly' in the imported model.

@VanessaE
Copy link
Author

Yep, now it looks right (and, those tips are actually just what I was doing 😃 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants