Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server Crash with More Chest Variants #31

Open
davidzus opened this issue Feb 9, 2025 · 5 comments
Open

Server Crash with More Chest Variants #31

davidzus opened this issue Feb 9, 2025 · 5 comments

Comments

@davidzus
Copy link

davidzus commented Feb 9, 2025

"Describe the bug
When MoreChestVariants and Ledger are installed together on a Fabric server, interacting with a double chest (any variant from MoreChestVariants) causes the server to crash. The crash occurs due to a NullPointerException in Ledger’s ItemRemoveCallback.kt when the pos parameter returns null.

To Reproduce
Steps to reproduce the behavior:

  1. Install both MoreChestVariants v1.5.11 and Ledger v1.3.7 on a Fabric server.
  2. Place two variant chests adjacent to each other to form a double chest.
  3. Insert or remove an item from the double chest.
  4. Server crashes immediately upon inventory interaction.

Expected behavior
The server should handle inventory transactions without crashing. The expected behavior is for Ledger to log the item change and for the chest to function normally. Instead, the server crashes due to a null value for the block position (pos) in Ledger’s callback.

Screenshots
If applicable, add screenshots to help explain your problem.

Versions (please complete the following information):

  • Minecraft: 1.21.4
  • Mod Version: 1.5.11
  • Mod loader: Fabric
  • Mod loader version: Fabric 1.6.10
  • Ledger Version: 1.3.7

Additional context
Crash Report: https://pastebin.com/sA57GKRF

"java.lang.NullPointerException: Parameter specified as non-null is null: method com.github.quiltservertools.ledger.callbacks.ItemInsertCallback$DefaultImpls.EVENT$lambda$1$lambda$0, parameter pos
at knot//com.github.quiltservertools.ledger.callbacks.ItemInsertCallback$DefaultImpls.EVENT$lambda$1$lambda$0(ItemInsertCallback.kt)"

*please fill out as much information as possible. If any required fields are missing, the issue may be closed without any comments.

@LieOnLion
Copy link
Owner

That is odd. I am unsure exactly what I could do about this, have you made an issue on the Ledger mod about this?

@davidzus
Copy link
Author

davidzus commented Feb 9, 2025

Yes, I made an issue on the Ledger mod about this Issue

@LieOnLion
Copy link
Owner

Could you reference it? I don't seem to see it

Image

@LieOnLion
Copy link
Owner

@davidzus
Copy link
Author

davidzus commented Feb 9, 2025

Ah sorry, I opened a Discord Issue, and i have referenced the #302 issue, since other players have same issues with other Chest mods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants