You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The template test test_classifier.py does not pass when triggered as a GitHub action.
The issue comes from imports. Indeed the import from project.datasets.mnist import mnist is erroneous. There is no datasets folder in project because datasets is ignored (see l.37 of .gitignore).
Pulling the MNIST dataset everytime the GitHub action is triggered does not seem reasonable. My proposal would be to have a samples_datasets/ subfolder in test, not ignored, with a limited number of data points, and to use that for testing.
If anyone agree that it's a reasonable way to go, I'll create a PR :)
The text was updated successfully, but these errors were encountered:
Problem
The template test
test_classifier.py
does not pass when triggered as a GitHub action.The issue comes from imports. Indeed the import
from project.datasets.mnist import mnist
is erroneous. There is nodatasets
folder inproject
becausedatasets
is ignored (see l.37 of.gitignore
).Pulling the MNIST dataset everytime the GitHub action is triggered does not seem reasonable. My proposal would be to have a
samples_datasets/
subfolder in test, not ignored, with a limited number of data points, and to use that for testing.If anyone agree that it's a reasonable way to go, I'll create a PR :)
The text was updated successfully, but these errors were encountered: