Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get device name without hlsmi #240

Merged
merged 6 commits into from
Oct 17, 2024
Merged

Get device name without hlsmi #240

merged 6 commits into from
Oct 17, 2024

Conversation

jerome-habana
Copy link
Collaborator

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

jerome-habana and others added 3 commits September 26, 2024 04:20
Signed-off-by: Jerome <[email protected]>
Avoid opening a device unnecessarily

Signed-off-by: Jerome <[email protected]>
@jerome-habana jerome-habana changed the title Dummy: Update date Avoid unnecessary device open Sep 27, 2024
@ankitgola005
Copy link
Contributor

Manual validation results.

Category pytorch-lightning | pypi   pytorch-lightning | source   lightning | pypi   lightning | source  
  G1 G2 G1 G2 G1 G2 G1 G2
HPU General tests Pass Pass Pass Pass Pass Pass Pass Pass
HPU torch compile tests Pass Pass Pass Pass Pass Pass Pass Pass
HPU FSDP tests Pass Pass Pass Pass Pass Pass Pass Pass
HPU Deepspeed tests Pass Pass Pass Pass Pass Pass Pass Pass
HPU precision test Pass Pass Pass Pass Pass Pass Pass Pass
Standalone-only single card tests Pass Pass Pass Pass Pass Pass Pass Pass
Multi card(2) HPU test Pass Pass Pass Pass Pass Pass Pass Pass
FSDP PT Multi card(2) HPU test Pass Pass Pass Pass Pass Pass Pass Pass
FSDP Fabric Multi card(2) HPU test Pass Pass Pass Pass Pass Pass Pass Pass
Testing HPU examples Pass Pass Pass Pass Pass Pass Pass Pass

@jerome-habana jerome-habana marked this pull request as ready for review October 17, 2024 07:19
@jerome-habana jerome-habana changed the title Avoid unnecessary device open Get device name without hlsmi Oct 17, 2024
Signed-off-by: Jerome <[email protected]>
@Borda Borda merged commit a33a6f3 into main Oct 17, 2024
15 of 20 checks passed
@Borda Borda deleted the dummy branch October 17, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants