Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transforming traces should always precede a domination check #1684

Open
ali-alshaar7 opened this issue Jan 22, 2025 · 1 comment
Open

Transforming traces should always precede a domination check #1684

ali-alshaar7 opened this issue Jan 22, 2025 · 1 comment
Assignees
Labels
enhancement New feature or request transforms

Comments

@ali-alshaar7
Copy link
Contributor

ali-alshaar7 commented Jan 22, 2025

🚀 Feature

Motivation

An improperly applied trace transformation can sometimes lead to domination errors in the data-flow graph. These often result in KeyError: 't* errors several blocks down the road. It would be helpful if more useful errors could be emitted earlier on.

Pitch

A transform that creates domination errors e.g (A = Node(C, B); C = Node(X) # where C's definition proceeds its use) will have a check that's applied after every transform is applied indicate the error and its location in the trace.

cc: @t-vi

@ali-alshaar7 ali-alshaar7 added the enhancement New feature or request label Jan 22, 2025
@ali-alshaar7 ali-alshaar7 self-assigned this Jan 22, 2025
@t-vi
Copy link
Collaborator

t-vi commented Jan 24, 2025

Thank you, great point, I'd see this as part of #1180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request transforms
Projects
None yet
Development

No branches or pull requests

3 participants