Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid name collisions in _convert_pytorchfunc_to_thundertrace #1777

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Avoid name collisions in _convert_pytorchfunc_to_thundertrace #1777

wants to merge 1 commit into from

Conversation

crcrpar
Copy link
Collaborator

@crcrpar crcrpar commented Feb 18, 2025

What does this PR do?

Fixes #1776.

@crcrpar crcrpar force-pushed the crpa/canonicalize_proxy_name_inside_custom_autograd_function_lookaside branch from 948cdcf to f142139 Compare February 20, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mruberry mruberry Awaiting requested review from mruberry mruberry will be requested when the pull request is marked ready for review mruberry is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga will be requested when the pull request is marked ready for review lantiga is a code owner

@t-vi t-vi Awaiting requested review from t-vi t-vi will be requested when the pull request is marked ready for review t-vi is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_interpret_call could reuse names in a trace when it's called in the lookaside of torch.autograd.Function
1 participant
@crcrpar