From 60219b39c14bac0e114fa437a654d92e5577e0ee Mon Sep 17 00:00:00 2001 From: riccardofelluga <11768013+riccardofelluga@users.noreply.github.com> Date: Sat, 14 Dec 2024 12:30:10 +0200 Subject: [PATCH] Revert "disable flaky test (#1255)" This reverts commit 67d8df6aa90258375decb2f2c9f67e77d3e52e79. --- thunder/tests/test_grad.py | 6 ------ 1 file changed, 6 deletions(-) diff --git a/thunder/tests/test_grad.py b/thunder/tests/test_grad.py index aab2f0d519..4520f517b1 100644 --- a/thunder/tests/test_grad.py +++ b/thunder/tests/test_grad.py @@ -1493,9 +1493,6 @@ def test_populate_grads_mlp(executor, device, dtype): @instantiate(dtypes=(thunder.float32,)) def test_populate_grads_csa(executor, device, dtype): - if version_between(torch.__version__, min_ver="2.6.0dev0", max_ver="2.6.0"): - pytest.skip("https://github.com/Lightning-AI/lightning-thunder/issues/1254") - from thunder.benchmarks import NanoGPTCSABenchmark, NanoGPTConfig # NOTE Currently setting dropout to zero for reproducibility, other settings taken from gpt2 config @@ -1523,9 +1520,6 @@ def test_populate_grads_csa(executor, device, dtype): @instantiate(dtypes=(thunder.float32,)) def test_populate_grads_block(executor, device, dtype): - if version_between(torch.__version__, min_ver="2.6.0dev0", max_ver="2.6.0"): - pytest.skip("https://github.com/Lightning-AI/lightning-thunder/issues/1254") - from thunder.benchmarks import NanoGPTBlockBenchmark, NanoGPTConfig # NOTE Currently setting dropout to zero for reproducibility, other settings taken from gpt2 config