Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

References to the *_epoch_end hooks in Lightning 2.0 #2100

Closed
awaelchli opened this issue Sep 22, 2023 · 0 comments · Fixed by #2118
Closed

References to the *_epoch_end hooks in Lightning 2.0 #2100

awaelchli opened this issue Sep 22, 2023 · 0 comments · Fixed by #2118
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@awaelchli
Copy link
Contributor

📚 Documentation

There are a few references in the docs where *_epoch_end() is mentioned, mostly when resetting metrics manually. In Lightning 2.0, these hooks got changed.

training_epoch_end(self, outputs) -> on_train_epoch_end(self)
validation_epoch_end(self, outputs) -> on_validation_epoch_end(self)
etc.

Most references have already been updated, but a few leftovers exist:
https://torchmetrics.readthedocs.io/en/latest/pages/overview.html#metriccollection
https://torchmetrics.readthedocs.io/en/latest/pages/lightning.html#logging-torchmetrics

I can send a PR for this

@awaelchli awaelchli added the documentation Improvements or additions to documentation label Sep 22, 2023
@SkafteNicki SkafteNicki added this to the v1.3.0 milestone Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants