Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New segmentation metric: Hausdorff Distance #2122

Open
wants to merge 37 commits into
base: master
Choose a base branch
from

Conversation

matsumotosan
Copy link
Member

@matsumotosan matsumotosan commented Oct 1, 2023

What does this PR do?

Fixes #1990

Before submitting
  • [x ] Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2122.org.readthedocs.build/en/2122/

@Borda
Copy link
Member

Borda commented Dec 18, 2023

Seems like a big collision. Could you check it or maybe cherry-pick your commits on top of the master?

matsumotosan and others added 6 commits May 21, 2024 11:06
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

Attention: Patch coverage is 46.57534% with 39 lines in your changes missing coverage. Please review.

Project coverage is 32%. Comparing base (0990ecf) to head (3f4b68e).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (0990ecf) and HEAD (3f4b68e). Click for more details.

HEAD has 310 uploads less than BASE
Flag BASE (0990ecf) HEAD (3f4b68e)
Windows 12 2
python3.8 12 0
cpu 78 2
torch1.13.1+cpu 12 0
torch2.4.0+cpu 4 1
python3.11 10 1
torch1.12.1+cpu 4 0
Linux 52 0
python3.9 36 0
torch1.11.0+cpu 4 0
torch2.0.1+cpu 12 1
python3.10 20 1
gpu 3 0
unittest 3 0
torch1.10.2+cpu 4 0
macOS 14 0
torch2.0.1 8 0
torch1.13.1 4 0
torch2.3.1+cpu 8 0
torch2.2.2+cpu 8 0
torch2.4.0+cu121 4 0
torch2.1.2+cpu 4 0
torch2.4.0 2 0
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2122     +/-   ##
========================================
- Coverage      69%     32%    -37%     
========================================
  Files         334     322     -12     
  Lines       18153   18049    -104     
========================================
- Hits        12570    5736   -6834     
- Misses       5583   12313   +6730     

@Borda Borda force-pushed the master branch 2 times, most recently from d0a5568 to 9fc79ae Compare September 16, 2024 08:18
@Borda
Copy link
Member

Borda commented Sep 23, 2024

@baskrahmer how is it going here? :)

@baskrahmer
Copy link
Collaborator

baskrahmer commented Sep 24, 2024

@baskrahmer how is it going here? :)

@Borda there is an issue with the tests, related to running with DDP. Could you have a look?

Copy link

There was an error handling pipeline event b3600a50-df3c-4a97-a1e3-4e33eb8eb07e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request New metric
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Hausdorff distance as a new classification metric
5 participants