Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PR with notebooks #34

Open
Borda opened this issue Jun 14, 2021 · 1 comment
Open

Allow PR with notebooks #34

Borda opened this issue Jun 14, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Borda
Copy link
Member

Borda commented Jun 14, 2021

🚀 Feature

Simplify the user work such as passing the notebooks and we would internally convert to scripts and cleaned formating

Motivation

Less user flustration and smoother user experience as performing review in https://www.reviewnb.com

Alternatives

Add extra workflows to handle these situations

  • these notebooks will go to another branch staging
  • on PR to this special branch we run standard notebooks testing
  • on merge (commit to staging) we trigger converting to script and merge to main or create a new PR? (we new PR we have extra level safety and also most likely no actions will be triggered on bots merge event)
  • ISSUE: how to ensure that in the staging branch is only one notebook - after converting we re-create blank staging from main

Additional context

@edgarriba is not happy about converting notebooks to script and fixing issues on his own :P

@Borda Borda added enhancement New feature or request help wanted Extra attention is needed labels Jun 14, 2021
@edgarriba
Copy link
Contributor

++1 ReviewNB :)

@Borda Borda self-assigned this Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants