Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example workflow - why use niche custom nodes in example workflows? #83

Closed
quasiblob opened this issue Dec 20, 2024 · 3 comments
Closed

Comments

@quasiblob
Copy link

quasiblob commented Dec 20, 2024

Hi.

Could you please change the default Text-to-video example?

I don't like to usually complain about free things, but the "Flux Prompt Enhance" node isn't very popular. It only has 62 stars:

image

Now, low star count does NOT mean this extension could somehow be malicious (because it is not very popular), but the repo of this custom node also says this:

image

So basically seems like the author has stopped also developing it.

@Packsod
Copy link

Packsod commented Dec 22, 2024

I can give some suggestions. The example workflow already uses String Function 🐍, which supports regular expressions, so no additional nodes are needed for replacing specific words .
image

/(?i)\b(illustration|image|photo|photograph|shoot|picture)\b(?!-)/
This expression adds a negative lookahead to ignore words with a "-", so "photo-realistic" is not replaced by "video-realistic"
I know it looks complicated, but it can be done with a few fewer node groups.

@quasiblob
Copy link
Author

"I can give some suggestions." - thanks but it is not like I can't replace it (although in this case wouldn't bother to start fiddling with regex myself, as I barely remember anything about regex lol) I've installed too many custom nodes already. This seems to be a common trend with shared workflows on several sites. If it would be possible to avoid using some less popular nodes, then why not use the popular one instead? Even better, don't use any unnecessary custom nodes if possible, when sharing example workflows.

@Packsod
Copy link

Packsod commented Dec 22, 2024

This advice is for repo developers, they definitely have reasons to use these nodes, the pysssss node is almost a must if you want to increase your automation. I'm just saying the examples could be improved a bit.

For users, it is possible to completely remove all missing modules instead of installing it, as most of them have alternatives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants