Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transactions pagination #33

Open
vesparny opened this issue Sep 14, 2020 · 4 comments
Open

transactions pagination #33

vesparny opened this issue Sep 14, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@vesparny
Copy link

Hi, I see blockstream rteturns a max of 50 txs per addrress.
Is pagination already implemented in the code or you only show the last 50 transactions?

Thanks

@KayBeSee
Copy link
Collaborator

I don't do anything with pagination at the moment but most addresses only have two transactions: one incoming and one outgoing.

@vesparny
Copy link
Author

I see. I guess it could be a problem for xpubs used for DCA.
Imagine stacking sats every 3 days, in that case it would be easy to reach the limit of 50 transactions.

@KayBeSee
Copy link
Collaborator

From my understanding, it is 50 txs per address. Wallets that follow best practices don't reuse addresses, so when the user goes to the receive page, they are always given a fresh address with zero transactions associated with it.

In your example with DCA, unless there is auto withdraw to a specific address (I believe Swan does this) then yes I can see it hitting that limit but I don't think many folks do that. The 50 tx limit could also be hit if the user posted a static address somewhere (like a donation page) and had 50 people send money to it.

You're right though, for those weird edge cases, we should add logic in the tx fetching call to see if the response is 50 and if it is then making another request with the pagination value.

@KayBeSee KayBeSee added the enhancement New feature or request label Sep 15, 2020
@vesparny
Copy link
Author

yeah it's probably just an edge case. You are right.

@vesparny vesparny reopened this Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants