esp-qcom-image cleanup #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumag
reviewed
Dec 3, 2024
Change the default vfat sector size for the ESP qcom image from 512 to 4096, as the default is too small for UFS-based devices. This is required in order for the kernel to be able to mount the esp partition at runtime. Signed-off-by: Ricardo Salveti <[email protected]>
Default ESP partition size used for the targets depending on esp-qcom-image is 512MB, align the vfat image size with the expected partition size. Signed-off-by: Ricardo Salveti <[email protected]>
LINGUAS_INSTALL gets set based on the values set in IMAGE_LINGUAS, but the most common and documented variable for setting the image-based locales is IMAGE_LINGUAS. Signed-off-by: Ricardo Salveti <[email protected]>
Set IMAGE_FEATURES to empty as there is no need to include standard IMAGE_FEATURES on the ESP image, since it should only contain UKI + systemd-boot. Signed-off-by: Ricardo Salveti <[email protected]>
systemd-bootconf is not required with type Linaro#2 boot loader entries (UKIs), and it is currently not used at runtime. Signed-off-by: Ricardo Salveti <[email protected]>
OE creates a set of directories and files which are desired on standard images, but are not required for ESP as this is a minimal non-rootfs standard image. Remove everything but the 'EFI' folder from the ESP image via a custom IMAGE_PREPROCESS_COMMAND command, as the base files and directories are needed during the rootfs task. Signed-off-by: Ricardo Salveti <[email protected]>
ricardosalveti
force-pushed
the
esp-qcom-image
branch
from
f3d4036 to
f5c1048
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve esp-qcom-image to make it aligned with the partition size and with the correct files for an ESP partition.
Fixes: