Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test version parameter #3

Closed
danrue opened this issue Feb 7, 2018 · 3 comments
Closed

Add test version parameter #3

danrue opened this issue Feb 7, 2018 · 3 comments

Comments

@danrue
Copy link
Contributor

danrue commented Feb 7, 2018

It may be desirable to have different skipfiles based on the version of a test suite that is being run.

For example, let's say we run kselftest version 4.15 and also kselftest version 4.4 against the same target board/branch/environment. As skipgen is currently written, the skipfile would have to be the same for both runs.

Creating a parameter for the skipfile called "test_version" could be used to change the generated skiplist based on which test version is being run.

Example (contrived) implementation, for a kselftest skipfile. This would skip test named 'fsgsbase_64' when running against branch 4.4, and when using kselftest version 4.15.

  - reason: >
      LKFT: mainline: x86: kselftests fsgsbase_64 failed - GS/BASE changed from
      0x1/0x0 to 0x0/0x0
      Fails intermittently
    url: https://bugs.linaro.org/show_bug.cgi?id=3596
    environments: production
    boards: x86
    branches:
      - 4.4
    test_versions:
      - 4.15
    tests:
      - fsgsbase_64
@danrue
Copy link
Contributor Author

danrue commented Feb 7, 2018

Curious on your thoughts on this @mwasilew @roxell and Naresh (what's his github name?)

@mwasilew
Copy link

mwasilew commented Feb 7, 2018

@danrue I believe Naresh's username is @nareshkamboju (https://github.com/nareshkamboju)

@danrue
Copy link
Contributor Author

danrue commented Mar 27, 2018

Closing in favor of #4

@danrue danrue closed this as completed Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants