Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool table widget: expand for column "rotation" #3064

Open
hansu opened this issue Aug 11, 2024 · 9 comments
Open

Tool table widget: expand for column "rotation" #3064

hansu opened this issue Aug 11, 2024 · 9 comments

Comments

@hansu
Copy link
Member

hansu commented Aug 11, 2024

I wonder if there was a specific reason to display the rotational offset not as a column for every coordinate system.
Was it just a matter of space and the rare use case?
@c-morley ?

Current:
grafik

Proposal:
grafik

@Sigma1912
Copy link
Contributor

I agree. This makes much more sense as each WCS has it's own 'R' value.

@andypugh
Copy link
Collaborator

And having a spurious rotation is an occasional cause of trouble. (I saw a recent forum post where someone said that their X and Y axes had swapped. That was the cause.

@c-morley
Copy link
Collaborator

Does each system have it's own rotation? I thought the rotation was was separate and added after the user system.

@Sigma1912
Copy link
Contributor

Yes, each system has it's own rotation. AxisGUI displays R values correctly for each system.

@hansu
Copy link
Member Author

hansu commented Aug 19, 2024

@c-morley
Copy link
Collaborator

What python attribute gives the rotation setting for systems not in use?
rotation_xy only gives the current rotation.

@Sigma1912
Copy link
Contributor

As far as I'm aware there are only python attributes for for the currently active WCS system. I think one would have to query parameters #5230 + i*20, i=[0..8]

@c-morley
Copy link
Collaborator

Ahh yes ,it's coming back to me now. We read the var file directly for the other user systems. I assume there is a var in that file for the other rotations too.

@hansu
Copy link
Member Author

hansu commented Aug 26, 2024

@c-morley Are you currently working on this? If yes - I thought it would be nice if we could use the calculator widget to enter the offset values. What do you think?

@hansu hansu changed the title Tool table wiodget: expand for column "rotation" Tool table widget: expand for column "rotation" Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants