From d1afdf6952fc1eb41bc338e0dff1e3b1b3d2ef7a Mon Sep 17 00:00:00 2001
From: Marco Benedetti <marco.benedetti@linuxfabrik.ch>
Date: Fri, 31 Jan 2025 14:40:05 +0100
Subject: [PATCH] fix(whmcs-status): handle null correctly in whmcs api
 response

---
 check-plugins/whmcs-status/unit-test/stdout/EXAMPLE02 | 4 +++-
 check-plugins/whmcs-status/unit-test/stdout/EXAMPLE03 | 4 +++-
 check-plugins/whmcs-status/whmcs-status               | 2 ++
 3 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/check-plugins/whmcs-status/unit-test/stdout/EXAMPLE02 b/check-plugins/whmcs-status/unit-test/stdout/EXAMPLE02
index 911320fbc..3aacfd54d 100644
--- a/check-plugins/whmcs-status/unit-test/stdout/EXAMPLE02
+++ b/check-plugins/whmcs-status/unit-test/stdout/EXAMPLE02
@@ -170,6 +170,8 @@
         "severityLevel": "info",
         "body": "<p>Your PHP version <strong>8.1.31</strong> is supported by WHMCS. </p><p>Your PHP version does not receive regular updates but is the latest supported by WHMCS.</p>"
       }
-    ]
+    ],
+    "warning": null,
+    "danger": null
   }
 }
diff --git a/check-plugins/whmcs-status/unit-test/stdout/EXAMPLE03 b/check-plugins/whmcs-status/unit-test/stdout/EXAMPLE03
index a5f8cb86d..08573fdb2 100644
--- a/check-plugins/whmcs-status/unit-test/stdout/EXAMPLE03
+++ b/check-plugins/whmcs-status/unit-test/stdout/EXAMPLE03
@@ -164,6 +164,8 @@
         "severityLevel": "notice",
         "body": "WHMCS is not running behind a CloudFlare proxy."
       }
-    ]
+    ],
+    "warning": null,
+    "danger": null
   }
 }
diff --git a/check-plugins/whmcs-status/whmcs-status b/check-plugins/whmcs-status/whmcs-status
index 297c78897..d405d77b2 100755
--- a/check-plugins/whmcs-status/whmcs-status
+++ b/check-plugins/whmcs-status/whmcs-status
@@ -149,6 +149,8 @@ def get_failed_checks(checks):
     """
     failed_checks = []
     for _, items in checks.get('checks', {}).items():
+        if items is None:
+            continue
         for item in items:
             if item.get('severityLevel') == 'notice':
                 continue