Skip to content
This repository has been archived by the owner on Jan 14, 2022. It is now read-only.

Custom filter applies senderId and recipientId by OR operator instead of AND #256

Open
sgdias opened this issue Aug 17, 2017 · 1 comment

Comments

@sgdias
Copy link

sgdias commented Aug 17, 2017

Expected behaviour

I'm expecting that if I combine both sender and receipt addresses I should be seeing all tx exclusivelly having both.

Actual behaviour

Instead I'm seeing not only the tx having both but also any of them.
It seems to me the filter is resolving the query using an OR operation in between fields.
I believe for basic use cases the filter should use an AND operation, ideally on an advanced filtering I should be able to specify OR / AND operations in between fields or use a regular expression to specify the logic I desire for my query.

Steps to reproduce

  1. Look up for any address receiving (address A) Lisks from a pool (address B)
  2. Add the receipt address field at the filer using A as the value
  3. Add the sender address field at the filter using B as the value
  4. Check that all visible tx are exclusivelly between A & B

Note: Whenever the filter is used, the result it's no longer consider the address details being see at the moment, any query happens across all addresses, from a user experience perspective this could be confusing because I could see tx not at all related to the current address details I'm seeing.

@reyraa reyraa changed the title Filtering feature not covering basic use cases Custom filter applies senderId and recipientId by OR operator instead of AND Aug 25, 2017
@reyraa reyraa added the *medium label Aug 28, 2017
@reyraa
Copy link
Contributor

reyraa commented Oct 25, 2017

Since this filter tools is implemented in the address page, the resulting transactions should belong to the address the page belongs to. e. g. if we are in /address/123456789L either senderID or recipientId should be 123456789L. or else this filter should be in a separated search page.

This is how I'm going to tweak this feature, given that we are in /address/123456789L:

  • If you enter 987654321L as recipientId then 123456789L is senderId.
  • If you enter 987654321L as senderId then 123456789L is recipientId.
  • If you enter 123456789L as either senderId or recipientId, the behaviour is similar to what we have in filter buttons (leaving the other Id free).
  • If you enter non of recipientId and senderId, the result is all the transaction in which either senderId or recipientId is 123456789L.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants