From 81f650aa995402fcea08bd80b203b6d6b4a87c8f Mon Sep 17 00:00:00 2001 From: Matjaz Verbole Date: Tue, 10 Dec 2024 10:55:48 +0100 Subject: [PATCH] Apply review suggestions --- script/upgraded/deployPriceFeedWithoutRoundsV2.sh | 8 ++++---- test/L2/L2PriceFeedWithoutRounds.t.sol | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/script/upgraded/deployPriceFeedWithoutRoundsV2.sh b/script/upgraded/deployPriceFeedWithoutRoundsV2.sh index e6605e03..21c5a659 100755 --- a/script/upgraded/deployPriceFeedWithoutRoundsV2.sh +++ b/script/upgraded/deployPriceFeedWithoutRoundsV2.sh @@ -12,17 +12,17 @@ echo "Setting environment variables..." source .env echo "Done." -echo "Creating $NETWORK directory inside deployment directory..." +echo "Creating $NETWORK directory inside deployment/artifacts/contracts directory..." if [ -z "$NETWORK" ] then echo "NETWORK variable inside .env file is not set. Please set NETWORK environment variable." exit 1 else - if [ -d "deployment/$NETWORK" ] + if [ -d "deployment/artifacts/contracts/$NETWORK" ] then - echo "Directory deployment/$NETWORK already exists." + echo "Directory deployment/artifacts/contracts/$NETWORK already exists." else - mkdir deployment/$NETWORK + mkdir deployment/artifacts/contracts/$NETWORK fi fi echo "Done." diff --git a/test/L2/L2PriceFeedWithoutRounds.t.sol b/test/L2/L2PriceFeedWithoutRounds.t.sol index 13ce3bdb..a294d38a 100644 --- a/test/L2/L2PriceFeedWithoutRounds.t.sol +++ b/test/L2/L2PriceFeedWithoutRounds.t.sol @@ -12,8 +12,8 @@ contract L2PriceFeedWithoutRoundsTest is Test { L2PriceFeedWithoutRounds public l2PriceFeed; L2PriceFeedWithoutRounds public l2PriceFeedImplementation; - address public priceFeedAdapter = 0x1038999DCf0A302Cc8Eed72fAeCbf0eEBfC476b0; - address public newPriceFeedAdapter = 0x2038999Dcf0A302cc8eeD72fAECbF0EebFc476b1; + address public priceFeedAdapter = vm.addr(uint256(bytes32("priceFeedAdapter"))); + address public newPriceFeedAdapter = vm.addr(uint256(bytes32("newPriceFeedAdapter"))); function setUp() public { // deploy L2PriceFeedWithoutRoundsFactory Implementation contract