Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full HTML code is reported again when reading inline images with a screen reader #689

Open
pvagner opened this issue Dec 26, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@pvagner
Copy link
Contributor

pvagner commented Dec 26, 2024

Hello,
It looks as the issue #569 is back.
When reading post that includes custom emojis e.g. the one we were testing in the original issue with a screen reader the whole HTML img tag is being included as a part of the text.
When reading that post, I can identify exactly the whole HTML img tag in the output like this:

<img src="https://assets.chaos.social/custom_emojis/images/000/299/341/original/0e9f801df9f74cbe.png" alt=":BoostOK:" />

I am also trying to find out if I can make it work however I am paying extra attention since there were follow up fixes to this part of the code.

@pvagner pvagner added the bug Something isn't working label Dec 26, 2024
@AkesiSeli
Copy link
Collaborator

Ok, I'll have a look at it... In the next weeks I'll be busy because I'm moving to a new house but I'll try! In any case version 0.4.0 won't be released until all issues in the beta are solved, thanks for testing it so soon.

@AkesiSeli
Copy link
Collaborator

I could not reproduce the issue but looking for it I found another one: if there were <img /> elements embedded in a post text, the UI of the app was broken with a bug similar to the one described in #607 which I thought I had solved. I created #692 to solve it and incidentally simplified TextWithCustomEmojis so maybe now the issue is clearer. The "culprit" may be the test in the looksLikeAnEmoji because some images with an alt text in the form of :something: could not be recognized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants